From e3fc4b40e2157457f6ec42921a602a85fb065c52 Mon Sep 17 00:00:00 2001 From: Nate Date: Wed, 14 May 2025 08:24:42 -0700 Subject: [PATCH] chore: :rotating_light: fix lint errors in gui and introduce gui lint in CI --- .github/workflows/pr_checks.yaml | 3 ++- gui/.eslintrc.json | 2 +- gui/package.json | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr_checks.yaml b/.github/workflows/pr_checks.yaml index 56920694f..eec79f4c6 100644 --- a/.github/workflows/pr_checks.yaml +++ b/.github/workflows/pr_checks.yaml @@ -235,10 +235,11 @@ jobs: cd packages/config-yaml npm run build - - name: Type check + - name: Type check and lint run: | cd gui npx tsc --noEmit + npm run lint binary-checks: needs: [install-root, install-core, install-config-yaml] diff --git a/gui/.eslintrc.json b/gui/.eslintrc.json index 462fd5592..aebab49dd 100644 --- a/gui/.eslintrc.json +++ b/gui/.eslintrc.json @@ -3,7 +3,7 @@ "parser": "@typescript-eslint/parser", "plugins": ["@typescript-eslint", "eslint-plugin-react"], "parserOptions": { - "project": "gui/tsconfig.json" + "project": ["tsconfig.json", "tsconfig.node.json"] }, "extends": [ // "eslint:recommended", diff --git a/gui/package.json b/gui/package.json index 4710796ea..de6da1959 100644 --- a/gui/package.json +++ b/gui/package.json @@ -12,7 +12,8 @@ "test": "vitest run", "test:coverage": "vitest run --coverage", "test:ui": "vitest --ui", - "test:watch": "vitest" + "test:watch": "vitest", + "lint": "eslint --ext ts" }, "dependencies": { "@continuedev/config-yaml": "file:../packages/config-yaml",